Determine queue topology without checking queue type #13697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What? This commit determines the queue topology without checking the queue type. ## Why? This way, checking leader and replicas works the same across all queue types without the need to introduce other rabbit_queue_type behaviour as suggested in other PRs. ## How? pid is the leader, nodes in queue_type_states are the members/replicas. This commit results in an unknown stream leader during queue declaration. However the correct leader will be returned eventually when calling GET on the stream.
kjnilsson
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This commit determines the queue topology without checking the queue type.
Why?
This way, checking leader and replicas works the same across all queue types without the need to introduce other rabbit_queue_type behaviour as suggested in other PRs.
How?
pid is the leader, nodes in queue_type_states are the members/replicas.
This commit results in an unknown stream leader during queue declaration. However the correct leader will be returned eventually when calling GET on the stream.